NModel Work Item Rss Feed

Closed Issue: An action term created in the stepper reaches the model with modified arguments [3662]

jpe — Thu, 16 May 2013 08:33:25 GMT

An action term created in the stepper and passed to the model from a class implementing the IStepper interface sometimes reaches the model with modified values. The action sometimes gets replaced in the WeakCache with an earlier instantiation of arguments. The error sometimes occurs on .Net but did not occur with the same code on Mono.

Created Issue: Null 'namespace' bug [9955]

victorsamun — Thu, 23 Feb 2012 08:39:45 GMT

Compiler may generate class '__StaticArrayInitTypeSize=%d' with null namespace but ReflectionHelper.IsCompilerGenerated returns 'false'.
ReflectionHelper.IsInModel method fails on this class.

Created Issue: Mpv.exe crashes in Windows 7 x64 due to GLEE [7024]

jpe — Tue, 24 Aug 2010 12:57:00 GMT

This issue was discovered by minhquang104 in thread [discussion:224398].

Mpv.exe crashes in Windows 7 x64 with the following error message. The MPV window remains blank with a red cross on it.

The problem does not occur in fresh installation of Windows 7 x64, but is introduced by recent Windows updates.

The problem is related to how the GLEE library uses Windows native GDI API.

************** Exception Text **************
System.ArgumentException: Parameter is not valid.
at System.Drawing.Graphics.set_Transform(Matrix value)
at Microsoft.Glee.GraphViewerGdi.GViewer.DotOnPaint(Graphics g, Boolean forPrinting)
at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer, Boolean disposeEventArgs)
at System.Windows.Forms.Control.WmPaint(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4952 (win7RTMGDR.050727-4900)
CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v2.0.50727/mscorlib.dll
----------------------------------------
mpv
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Program%20Files%20(x86)/NModel/bin/mpv.exe
----------------------------------------
NModel
Assembly Version: 1.0.21029.0
Win32 Version: 1.0.21029.0
CodeBase: file:///C:/Program%20Files%20(x86)/NModel/bin/NModel.DLL
----------------------------------------
NModel.Visualization
Assembly Version: 1.0.21029.0
Win32 Version: 1.0.21029.0
CodeBase: file:///C:/Program%20Files%20(x86)/NModel/bin/NModel.Visualization.DLL
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
Microsoft.GLEE.Drawing
Assembly Version: 1.2.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Program%20Files%20(x86)/NModel/bin/Microsoft.GLEE.Drawing.DLL
----------------------------------------
NewsReaderModel
Assembly Version: 0.0.0.0
Win32 Version: 0.0.0.0
CodeBase: file:///C:/Users/minhquang104/Desktop/Quang/NModel/Samples/NewsReader/bin/NewsReaderModel.dll
----------------------------------------
System.Configuration
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Xml
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Accessibility
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/Accessibility/2.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
Microsoft.Glee.GraphViewerGDI
Assembly Version: 1.2.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Program%20Files%20(x86)/NModel/bin/Microsoft.Glee.GraphViewerGDI.DLL
----------------------------------------
Microsoft.GLEE
Assembly Version: 1.2.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Program%20Files%20(x86)/NModel/bin/Microsoft.GLEE.DLL
----------------------------------------
System.Design
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Design/2.0.0.0__b03f5f7f11d50a3a/System.Design.dll
----------------------------------------

Created Issue: ct without logfile crashes at end [5158]

jgoertz — Wed, 06 Jan 2010 07:32:26 GMT

Run failed. Object reference not set to an instance of an object.
at NModel.Conformance.ConformanceTester.AddMetricsToEndOfLog() in c:\programs
\NModel\src\NModel\Conformance\ConformanceTesterMetrics.cs:line 70

AddMetricsToEndOfLog calls sw.WriteLine(")") but should use WriteLine(sw,")")

Created Issue: mp2dot adds line break - bug? [5152]

mathume — Tue, 05 Jan 2010 17:01:29 GMT

I'm using mp2dot which was compiled by gmcs - Mono C# compiler version 2.4.2.3 on a Ubuntu Karmic Koala installation - Linux kernel 2.6.31.16: mp2dot /dot:editor.dot /r:Test.dll Editor.Factory.Create, where Test.dll was compiled by the same gmcs.

The output file editor.dot then contains a line break which throws an error in in the graphviz dot-tools dot, neato and also in xdot.

Might be minor but it seems to me to be a bug.

Commented Feature: State variables using mp2dot? [3242]

mathume — Mon, 21 Dec 2009 20:15:58 GMT

I've discussed this with the other developers and for now we will handle it like this: you can submit the file(s) you added or changed and we will evaluate them, test them, and (if all is well) merge them into the source code repository.

I will create a Work Item in the Issue Tracker for this. Then (I think) you can attach your files to that work item.

Jon
Comments: ** Comment from web user: mathume **

Hello there! Thanks for your great work. Are there any advances on this item and how can I use the functionality with mp2dot?

Closed Issue: Isomorphism checking does not support composition

jpe — Sun, 17 May 2009 20:00:58 GMT

Isomorphism checking code in NModel release 1.0.21029.0 does not support model composition. Symptoms are errors like described in http://www.codeplex.com/NModel/Thread/View.aspx?ThreadId=42719
Comments: Fixed in change set 23295.

Commented Issue: An action term created in the stepper reaches the model with modified arguments

jpe — Sun, 17 May 2009 19:58:52 GMT

A fix is uploaded in change set 23445.

Created Issue: An action term created in the stepper reaches the model with modified arguments

jpe — Sun, 17 May 2009 19:56:25 GMT

Commented Issue: Finding Type of sort in a models' composition

jpe — Sun, 17 May 2009 15:48:18 GMT

Hi,

I was trying to create a product out of two models that reside in two different assemblies.
When executing the mpv utility I have got the “No default type for sort ...” exception.

I looked at the source code and I think that I have found the cause of the problem.
I have implemented a few changes in the source code of NModel which solved my issue.
It seems now that the composition of these two different assemblies works.
I compared it with a composition of the same two models but with an implemented architecture of a model and a feature (which works without any issues with the original NModel source) and it looks that I get the same results.

I am attaching the code changes I did.
Since these code-changes touch the NModel internals, I would appreciate it if you could check it and make sure that it doesn't hurt the NModel intended design or functionality.

Obviously, if you find these changes beneficial, please feel free to use and implement them in Nmodel.

The package includes the summary of the code-changes (Ofer_sortType_codeChanges.cs.txt file) and the updated file itself (InterpretationContext.cs under the NModel directory).

Thank you,
Ofer
Comments: ** Comment from web user: jpe **

Hi!

> I think that the WebApplication continued to work before the code I added because it happens only in few
> occasions that 'User' and 'Password' are not found.

The sample worked fine before the patch and the User and Password enums were successfully cast to the CompoundTerm type.

The sample stops working because the patch finds the WebModel.User enum type but the library fails to later use that information to convert value of type WebModel.User into a CompoundTerm. The issue lies in that value types and objects are treated slightly differently.

Please note that the error produced is

Unable to cast object of type 'WebModel.User' to type 'NModel.Terms.CompoundTerm'.

and it has nothing to do with String.
I agree that it is more appropriate to use .ToString() instead of (string) cast to return a string value of a compound term argument but it is _not_ the cause of the error in this case. The error occurs when an attempt is made in the harness namespace to cast the first action argument to an enumeration defined in the model namespace. Just to illustrate, the action is

Login_Start(User("VinniPuhh"), Password("Correct"))

And the piece of code

((CompoundTerm)action[0])[0].ToString()

should result in a string containing "VinniPuhh". Your suggested Stepper.cs fix will return 'User("VinniPuhh")' and will break the code.

One possible fix is to exclude value types from the sort types for now by adding the following lines in front of the return statement in the getSortTypeFromAppDomainAssemblies() function:

+ // Value types need different handling
+ if (thisSortType != null && thisSortType.IsValueType)
+ thisSortType = null;

return thisSortType;

This fix will keep the multiple dll-s support that is required for the example provided in the thread.
I have not touched the InterpretationContext part of the code before therefore it is coming along slowly. Let's add and keep as much functionality as possible without breaking any old one unless it can be shown that the old functionality was broken. Currently the treating of enums needs some further work in the context of multiple dlls.
The fix suggested here was tested with the WebApplication example and it works as it used to with it.

Commented Issue: Finding Type of sort in a models' composition

oriver — Sun, 17 May 2009 07:46:13 GMT

The added code (search for a type in other assemblies) to the Type NModel.Internals.InterpretationContext. DefaultSortType(Symbol sort) is being executed only if this type is not found by all the previous search tries. This means that without this added code, if the execution reached that point, the method would throw an exception.
I did see that there are few times that the types 'User' and 'Password' are not found and that is why it reaches the search I added, which finds them.
I think that the WebApplication continued to work before the code I added because it happens only in few occasions that 'User' and 'Password' are not found.
I didn't go to deep into that, to understand what are the occasions that these types are not found in the first place and why now that they are found the behavior is changed, but I think that I solved this issue:

It seems to me that the casting from eNum the way it is done in the Stepper of the WebApplication is wrong.

The original casting in the stepper is:
(string)((CompoundTerm)action[0])[0]

If you change all the places that have this kind of casting to:
action[0].ToString()

Everything works again.

So, for instance, the line:
modelUserToRealUser.TryGetValue((string)((CompoundTerm)action[0])[0],out userName);

Should be:
modelUserToRealUser.TryGetValue(action[0].ToString(),out userName);

And also the switch line:
switch ((string)((CompoundTerm)action[1])[0])

Should be:
switch (action[1].ToString())

I am attaching the updated file so you can review it.

Commented Issue: Finding Type of sort in a models' composition

jpe — Mon, 11 May 2009 23:59:33 GMT

Apparently this patch has a side effect to the ConformanceTester functionality.

When this patch is applied ConformanceTester stops working in some cases. For example the WebApplication sample. Without this patch it works fine with the current revision 23333, but with it it produces the following error:

Initialize
Login_Start
TestResult(239, Verdict("Failure"), "Unable to cast object of type 'WebModel.User' to type 'NModel.Terms.CompoundTerm'.",
Trace(
Initialize(),
Login_Start(User("OleBrumm"), Password("Incorrect"))
)

The generation of this error can be traced down to the following function and line in ConformanceTester:

static void CallTheImplementation(object implAndActionAndRes)
{
object[] args = (object[])implAndActionAndRes;
try
{
-->> Action implAction = ((IStepper)args[0]).DoAction((Action)args[1]);
((ImplementationResultWrapper)args[2]).implAction = implAction;
}

catch (Exception e)
{
((ImplementationResultWrapper)args[2]).exception = e;
}
}

This corresponds to invoking the DoAction of the IStepper interface. The concrete adapter has a

using WebModel;

line to access the enumerations defined in the model. But the exception is thrown when calling the following line in the WebApplication/Adapter/Stepper.cs file:

modelUserToRealUser.TryGetValue((string)((CompoundTerm)action[0])[0],out userName); //"Vinnipuhh" -> "user1"

It needs to be investigated further how to solve the issue.

Closed Issue: Prevent action labels from obscure one another in dot and svg files

jon — Thu, 26 Mar 2009 21:24:24 GMT

Adding spaces at the beginning and ending of action labels to prevent labels from obscure one another in dot and svg files.
The changed NModel file is under the NModel directory.

Attaching the model of the RPS game (the one with deadlocks in the design)

Thank you,
Ofer
Comments: Ofer's changes are included in source code change set 22530, committed Mar 17, 2009

Closed Feature: State variables using mp2dot?

jon — Thu, 26 Mar 2009 21:21:10 GMT

Created Issue: State variables don't get updated when an object is deleted

oriver — Tue, 03 Mar 2009 14:11:48 GMT

Hi,

I have noticed that state variables don't get updated when an object is deleted.
In the attached sample please check a state that comes after a removal of an Employee object, for instance node #66 (around the middle of the fsm). You can see that 'AllEmployees' only contains Employee(2) but 'myCompany' contains also Employee(1) and Employee(3).

Please let me know whether I am doing something wrong here, or if you need more info.

Thank you,
Ofer

Commented Issue: Finding Type of sort in a models' composition

oriver — Sun, 01 Mar 2009 16:01:42 GMT

Attaching a sample: TwoModelsComposition.zip

Commented Feature: State variables using mp2dot?

oriver — Sun, 01 Mar 2009 15:44:42 GMT

Hi,

I have found out the place in the code where you create the tooltips for mpv :
method:
private string DefaultNodeTooltip(IState iState)
in:
NModel.Visualization.GraphView

And I saw that there is a condition which the code that I first attached don't handle: pairState (when having a product of 2 models).

Therefore I copied the mpv code to:
method:
private string DefaultNodeTooltip(IState iState)
in:
NModel.Utilities.Graph.GraphView

And added some small adaptations and the filtering abilities ([HideFromViewer] attribute and StateTooltipVars). The way I added them, these filters exist only in mp2dot.

It would be better of course to just use the above method but I can't since it is private, so I copied it.

So please look at this new code that I am submitting (Ofer_USE_THIS_CODE.zip) instead of the previous one.
Sorry for this confusion, I probably should have looked for this piece of code earlier.

I am attaching one more sample that creates a product model out of 2 models. To have this sample work you also have to implement my code suggestion for work-item #3255: "Finding Type of sort in a models' composition" which handles an exception when crating a model product using a composition of 2 models.

Thank you,
Ofer

Created Issue: Prevent action labels from obscure one another in dot and svg files

oriver — Thu, 26 Feb 2009 21:28:33 GMT

Commented Feature: State variables using mp2dot?

oriver — Thu, 26 Feb 2009 21:16:03 GMT

Attaching a code sample with an RPS model (with a good design).
I am going to attach the one with the wrong design (with the deadlocks which I have loaded its svg file above) to a next work item which I am going to open now (adding spaces to actions texts).

Created Issue: Finding Type of sort in a models' composition

oriver — Wed, 25 Feb 2009 11:13:53 GMT